hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Foley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7435) Make pre-commit checks run against the correct branch
Date Fri, 01 Jul 2011 00:54:30 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058159#comment-13058159
] 

Matt Foley commented on HADOOP-7435:
------------------------------------

Definitely a good idea. Does Hudson handle any arbitrary branch, or only ones that have a
current nightly build job?  

I'd be okay with a patch naming convention, and don't really like overloading "Fix versions".
 But there is one more piece of info available:  Patches generated with "svn diff" have svn
release numbers next to each pre-existing file name.  That release number should be uniquely
associated with a particular branch, which test-patch could identify and use.  But git patch
tags probably don't allow for the same trick.

At any rate, the patch naming convention has the advantage of letting the developer specify
what branch to test against.  That's probably the best approach.

> Make pre-commit checks run against the correct branch
> -----------------------------------------------------
>
>                 Key: HADOOP-7435
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7435
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>             Fix For: 0.23.0
>
>
> The Hudson pre-commit tests are presently only capable of testing a patch against trunk.
It'd be nice if this could be extended to automatically run against the correct branch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message