hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8093) HadoopRpcRequestProto should not be serialize twice
Date Mon, 20 Feb 2012 09:54:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211747#comment-13211747

Hadoop QA commented on HADOOP-8093:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/613//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/613//console

This message is automatically generated.
> HadoopRpcRequestProto should not be serialize twice
> ---------------------------------------------------
>                 Key: HADOOP-8093
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8093
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0, 0.23.2
>         Environment: Windows 7
>            Reporter: Changming Sun
>         Attachments: HADOOP-8093.patch
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>     @Override
>     public void write(DataOutput out) throws IOException {
>       out.writeInt(message.toByteArray().length);
>       out.write(message.toByteArray());
>     }
> The code is not effective.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message