hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9097) Maven RAT plugin is not checking all source files
Date Tue, 27 Nov 2012 12:31:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504572#comment-13504572
] 

Tom White commented on HADOOP-9097:
-----------------------------------

It looks like the plugin is configured to only check pom.xml in some places:

{noformat}
      <plugin>
        <groupId>org.apache.rat</groupId>
        <artifactId>apache-rat-plugin</artifactId>
        <configuration>
          <includes>
            <include>pom.xml</include>
          </includes>
        </configuration>
      </plugin>
{noformat}

We should change this to include everything by default, and list exclusions in cases where
it is not possible to add a license header (e.g. binary files). Service loader files (under
META-INF), can have headers added since # is recognized as a comment.
                
> Maven RAT plugin is not checking all source files
> -------------------------------------------------
>
>                 Key: HADOOP-9097
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9097
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.3-alpha, 0.23.5
>            Reporter: Tom White
>            Priority: Blocker
>             Fix For: 2.0.3-alpha, 0.23.6
>
>
> Running 'mvn apache-rat:check' passes, but running RAT by hand (by downloading the JAR)
produces some warnings for Java files, amongst others.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message