hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-6801) io.sort.mb and io.sort.factor were renamed and moved to mapreduce but are still in CommonConfigurationKeysPublic.java and used in SequenceFile.java
Date Sun, 02 Dec 2012 18:15:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508309#comment-13508309
] 

Harsh J commented on HADOOP-6801:
---------------------------------

Patch still applies to trunk. Any refinements needed?

Here's what the patch does:

1. Introduces two new properties: {{seq.io.sort.mb}} and {{seq.io.sort.factor}} that apply
to SequenceFile.Sorter classes alone, as replacements to the now-MR properties of {{io.sort.mb}}
and {{io.sort.factor}}.
2. Makes the SequenceFile.Sorter read these new properties, while paying more importance to
the older names.
3. Docs and read-tests on the new properties.
                
> io.sort.mb and io.sort.factor were renamed and moved to mapreduce but are still in CommonConfigurationKeysPublic.java
and used in SequenceFile.java
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-6801
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6801
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: HADOOP-6801.r1.diff, HADOOP-6801.r2.diff, HADOOP-6801.r3.diff, HADOOP-6801.r4.diff,
HADOOP-6801.r5.diff
>
>
> Following configuration keys in CommonConfigurationKeysPublic.java (former CommonConfigurationKeys.java):
> public static final String  IO_SORT_MB_KEY = "io.sort.mb";
> public static final String  IO_SORT_FACTOR_KEY = "io.sort.factor";
> are partially moved:
>   - they were renamed to mapreduce.task.io.sort.mb and mapreduce.task.io.sort.factor
respectively
>   - they were moved to mapreduce project, documented in mapred-default.xml
> However:
>   - they are still listed in CommonConfigurationKeysPublic.java as quoted above
>   - strings "io.sort.mb" and "io.sort.factor" are used in SequenceFile.java in Hadoop
Common project
> Not sure what the solution is, these constants should probably be removed from CommonConfigurationKeysPublic.java
but I am not sure what's the best solution for SequenceFile.java.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message