hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9112) test-patch should -1 for @Tests without a timeout
Date Tue, 04 Dec 2012 14:52:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509778#comment-13509778
] 

Robert Joseph Evans commented on HADOOP-9112:
---------------------------------------------

test-patch runs maven with -fn.  This means that maven will always return an exit code of
0, so we use grep to find test failures but if a test exits early then no xml file is generated
for that test.  which means that grep cannot find it. If we did not have the -fn then if one
test failed it could prevent other tests from running. We could change it so we capture the
output of running the test and then check for 

{noformat}
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
{noformat}

That always appears after failures even when mvn returned a 0.  Or we could try and find another
way to have maven detect the error.  -Dmaven.test.failure.ignore=true does similar things
to -fn but only for test failures.  Test errors like an unexpected exception being thrown,
a test timing out, or someone in the test calling system.exit will result in not running all
of the tests. I think adding in the BUILD FAILURE grep is preferable, but it will not tell
us in an easy way which tests timed out.
                
> test-patch should -1 for @Tests without a timeout
> -------------------------------------------------
>
>                 Key: HADOOP-9112
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9112
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Todd Lipcon
>
> With our current test running infrastructure, if a test with no timeout set runs too
long, it triggers a surefire-wide timeout, which for some reason doesn't show up as a failed
test in the test-patch output. Given that, we should require that all tests have a timeout
set, and have test-patch enforce this with a simple check

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message