hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chuan Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9364) PathData#expandAsGlob does not return correct results for absolute paths on Windows
Date Wed, 06 Mar 2013 02:34:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594258#comment-13594258
] 

Chuan Liu commented on HADOOP-9364:
-----------------------------------

+1

I am not so sure why we need the empty string check in Path though.
{code}
  private void checkPathArg( String path ) throws IllegalArgumentException {
    // disallow construction of a Path from an empty string
    if ( path == null ) {
      throw new IllegalArgumentException(
          "Can not create a Path from a null string");
    }
    if( path.length() == 0 ) {
       throw new IllegalArgumentException(
           "Can not create a Path from an empty string");
    }   
  }
{code}
                
> PathData#expandAsGlob does not return correct results for absolute paths on Windows
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-9364
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9364
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: trunk-win
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>         Attachments: HADOOP-9364.branch-trunk-win.pathdata.patch
>
>
> This causes {{FsShell ls}} not to work properly for absolute paths. For example:
> {code}
> -fs hdfs://127.0.0.1:58559 -ls -R /dir0
> {code}
> returns
> {code}
> drwxr-xr-x   - ivanmi supergroup          0 2013-03-05 11:15 ../../dir0/dir1
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message