hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Mitic (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9413) Introduce common utils for File#setReadable/Writable/Executable and File#canRead/Write/Execute that work cross-platform
Date Mon, 01 Apr 2013 02:07:15 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618560#comment-13618560

Ivan Mitic commented on HADOOP-9413:

Thanks Chris and Bikas for the review comments! 

Bikas, the current patch gets things moving forward on Windows and there are no changes to
the current behavior on non-Windows platforms. The patch just builds on top of the current
design where Hadoop sees Windows as a POSIX compatible OS w.r.t. local file system access.

Given Chris’ input from above where the previous logic from HADOOP-8973 works only on folders,
my take is to proceed with one of the following:
a. The approach from the current patch
b. JNI implementation which will handle access checks on the ACLs level and provide a more
natural integration with Windows

Let me spend a few days investigating what would it take to implement b) and understanding
the implications of this approach for Hadoop on Windows. It is definitely worth spending a
bit of time on this. If this turns out to be strait forward, I’ll address it as part of
this patch. If not, we can start with a new Jira and iterate thru problems. Let me know if
this sounds good.

> Introduce common utils for File#setReadable/Writable/Executable and File#canRead/Write/Execute
that work cross-platform
> -----------------------------------------------------------------------------------------------------------------------
>                 Key: HADOOP-9413
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9413
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>             Fix For: 3.0.0
>         Attachments: HADOOP-9413.commonfileutils.patch
> So far, we've seen many unittest and product bugs in Hadoop on Windows because Java's
APIs that manipulate with permissions do not work as expected. We've addressed many of these
problems on one-by-one basis (by either changing code a bit or disabling the test). While
debugging the remaining unittest failures we continue to run into the same patterns of problems,
and instead of addressing them one-by-one, I propose that we expose a set of equivalent wrapper
APIs that will work well for all platforms.
> Scanning thru the codebase, this will actually be a simple change as there are very few
places that use File#setReadable/Writable/Executable and File#canRead/Write/Execute (5 files
in Common, 9 files in HDFS).
> HADOOP-8973 contains additional context on the problem.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message