hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Joseph Evans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9426) Hadoop should expose Jar location utilities on its public API
Date Tue, 02 Apr 2013 15:07:17 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619905#comment-13619905
] 

Robert Joseph Evans commented on HADOOP-9426:
---------------------------------------------

That being said, I don't see much reason to have most of the other methods in there.  You
have grabbed a class that is designed for testing, and re-purposed it.  I see no reason to
automatically create a jar if the .class file is not in a jar already.  Especially placing
it in a directory defined by test.build.dir, and probably pointing to target/test-dir.  I
also see no reason to turn an IOException in a RuntimeException.  This is fine for testing,
but makes it more difficult to deal with exceptions correctly in other places.

I would much rather see ClassUtil.java be made public and stable.  It is what MR is using
anyways, although it still turns an IOException into a RuntimeException, but I guess you cannot
have everything.
                
> Hadoop should expose Jar location utilities on its public API
> -------------------------------------------------------------
>
>                 Key: HADOOP-9426
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9426
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 1.1.0, 2.0.0-alpha
>            Reporter: Nick Dimiduk
>         Attachments: 0001-HADOOP-9426-Promote-JarFinder-out-of-test-jar.patch, 0001-HADOOP-9426-Promote-JarFinder-out-of-test-jar.patch
>
>
> The facilities behind JobConf#setJarByClass and the JarFinder utility in test are both
generally useful. As the core platform, these should be published as part of the public API.
In addition to HBase, they are probably useful for Pig and Hive as well. See also HBASE-2588,
HBASE-5317, HBASE-8140.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message