hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Radia (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9683) Wrap IpcConnectionContext in RPC headers
Date Mon, 15 Jul 2013 17:28:53 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708678#comment-13708678
] 

Sanjay Radia commented on HADOOP-9683:
--------------------------------------

Correct the throws in Server.java - you have changed several methods to throw RpcReplyException
(which should be called WrappedRpcServerException as per my above comment). So far I have
noticed the following, but we should check all the methods in server  (eclipse helps here).
* server#processConnectionContext  - the exception thrown is RpcReply exception - in the javadoc
please specify that it throws the rpcReplyException whch wrap the AccessControlException and
which other one (does not seem to be RpcDeserializationException as mentioned in Javadoc).
* server#authorizeConnection should throw RpcReplyException

                
> Wrap IpcConnectionContext in RPC headers
> ----------------------------------------
>
>                 Key: HADOOP-9683
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9683
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc
>            Reporter: Luke Lu
>            Assignee: Daryn Sharp
>            Priority: Blocker
>         Attachments: HADOOP-9683.patch
>
>
> After HADOOP-9421, all RPC exchanges (including SASL) are wrapped in RPC headers except
IpcConnectionContext, which is still raw protobuf, which makes request pipelining (a desirable
feature for things like HDFS-2856) impossible to achieve in a backward compatible way. Let's
finish the job and wrap IpcConnectionContext with the RPC request header with the call id
of SET_IPC_CONNECTION_CONTEXT. Or simply make it an optional field in the RPC request header
that gets set for the first RPC call of a given stream.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message