hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9688) Add globally unique request ID to RPC requests
Date Wed, 03 Jul 2013 17:28:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699212#comment-13699212
] 

Chris Nauroth commented on HADOOP-9688:
---------------------------------------

I filed HADOOP-9691 to change the call ID sequence generation code separately.

The patch is looking good.  Just a few minor comments:

{code}
  /**
   * Returns the clientId from corresponding the RPC request
   */
{code}

Was this supposed to be "...from the corresponding RPC..."?

{code}
  @Test
  public void testRpcRequestID() {
    byte[] uuid = StringUtils.getUuidBytes();
    RpcRequestHeaderProto header = ProtoUtil.makeRpcRequestHeader(
        RpcKind.RPC_PROTOCOL_BUFFER, OperationProto.RPC_FINAL_PACKET, 0, uuid);
    Arrays.equals(uuid, header.getClientId().toByteArray());
  }
{code}

Can we rename this to {{testRpcClientID}} now that we switched from using a request ID to
a client ID?

The last line of the test evaluates a boolean result but doesn't assert anything about it.
 This was probably meant to call {{assertArrayEquals}}.

                
> Add globally unique request ID to RPC requests
> ----------------------------------------------
>
>                 Key: HADOOP-9688
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9688
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HADOOP-9688.clientId.patch, HADOOP-9688.patch
>
>
> This is a subtask in hadoop-common related to HDFS-4942 to add unique request ID to RPC
requests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message