hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9703) org.apache.hadoop.ipc.Client leaks threads on stop.
Date Thu, 11 Jul 2013 18:23:52 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706072#comment-13706072
] 

Colin Patrick McCabe commented on HADOOP-9703:
----------------------------------------------

This shouldn't actually need to be static, should it?

{code}
+    private static int executorRefCount = 0;
{code}

Might also add an assert(executorRefCount >= 0) to unref

+1 once that is addressed.  thanks Tsuyoshi
                
> org.apache.hadoop.ipc.Client leaks threads on stop.
> ---------------------------------------------------
>
>                 Key: HADOOP-9703
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9703
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: HADOOP-9703.1.patch, HADOOP-9703.2.patch
>
>
> org.apache.hadoop.ipc.Client#stop says "Stop all threads related to this client." but
does not shutdown the static SEND_PARAMS_EXECUTOR, so usage of this class always leaks threads
rather than cleanly closing or shutting down.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message