hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9778) Remove user name and group name validation logic from chown and chgrp shell commands.
Date Fri, 26 Jul 2013 17:59:50 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721002#comment-13721002
] 

Chris Nauroth commented on HADOOP-9778:
---------------------------------------

{quote}
Here's an idea: why not make the validation configurable?
{quote}

This could be a good compromise.  Something that just occurred to me is that we don't have
a way to express different default property values per platform in *-default.xml.  That might
be a handy thing to build.  Even without that, I suppose we could document this in core-default.xml
with commented-out XML.

{quote}
I don't think there is a great demand for zany user names, and if we shell-expand them in
even one place, we could have problems.
{quote}

Thanks, I hadn't considered this risk.  Configurability with a default would maintain the
current behavior and protect against this.

                
> Remove user name and group name validation logic from chown and chgrp shell commands.
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9778
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9778
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Chris Nauroth
>            Priority: Minor
>
> The chown and chgrp shell commands enforce a valid set of characters for user names and
group names.  The validation rules for user names and group names vary across different OSes,
so this is a portability problem and a maintenance burden.  It requires us to change the code
every time we discover a difference in the rules.  I propose that we remove this validation
logic and instead pass through input user names and group names to the OS.  We can handle
error reporting by catching errors returned from the OS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message