hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9527) Add symlink support to LocalFileSystem on Windows
Date Mon, 05 Aug 2013 23:53:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730156#comment-13730156
] 

Chris Nauroth commented on HADOOP-9527:
---------------------------------------

I'm +1 for committing the v10 patch and submitting subsequent jiras to address any lingering
clean-up activities, which appear to be minor at this point.

Regarding letting the test fail, I agree with the concept in general as a dev process.  Unfortunately,
I don't think it interacts well with the established Apache patch workflow.  If we committed
v11, then Jenkins would -1 every patch, and it could mask new failures introduced in later
file system patches.  (Arpit stated earlier that it's not a Windows-specific problem.  It
happens on Linux too.)  There are other examples in the code of leaving a TODO and mentioning
a jira, so this appears to be acceptable if used in moderation.

                
> Add symlink support to LocalFileSystem on Windows
> -------------------------------------------------
>
>                 Key: HADOOP-9527
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9527
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.3.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HADOOP-9527.001.patch, HADOOP-9527.002.patch, HADOOP-9527.003.patch,
HADOOP-9527.004.patch, HADOOP-9527.005.patch, HADOOP-9527.006.patch, HADOOP-9527.007.patch,
HADOOP-9527.008.patch, HADOOP-9527.009.patch, HADOOP-9527.010.patch, HADOOP-9527.011.patch,
RenameLink.java
>
>
> Multiple test cases are broken. I didn't look at each failure in detail.
> The main cause of the failures appears to be that RawLocalFS.readLink() does not work
on Windows. We need "winutils readlink" to fix the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message