hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-9652) RawLocalFs#getFileLinkStatus does not fill in the link owner and mode
Date Fri, 09 Aug 2013 18:46:49 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Wang updated HADOOP-9652:
--------------------------------

    Attachment: hadoop-9652-5.patch

Okay, one more rev! I had to rebase since some windows fixes have gone in, so some attention
would be good.

I went through and renamed the now-deprecated methods to {{deprecated*}}, and moved the OS
support check into a final boolean like you suggested. Also tried to minimize the diff.

I again ran the tests that failed the last time this was committed, as well as a few in common/HDFS.
                
> RawLocalFs#getFileLinkStatus does not fill in the link owner and mode
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-9652
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9652
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Andrew Wang
>             Fix For: 2.3.0
>
>         Attachments: hadoop-9452-1.patch, hadoop-9652-2.patch, hadoop-9652-3.patch, hadoop-9652-4.patch,
hadoop-9652-5.patch
>
>
> {{RawLocalFs#getFileLinkStatus}} does not actually get the owner and mode of the symlink,
but instead uses the owner and mode of the symlink target.  If the target can't be found,
it fills in bogus values (the empty string and FsPermission.getDefault) for these.
> Symlinks have an owner distinct from the owner of the target they point to, and getFileLinkStatus
ought to expose this.
> In some operating systems, symlinks can have a permission other than 0777.  We ought
to expose this in RawLocalFilesystem and other places, although we don't necessarily have
to support this behavior in HDFS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message