hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (HADOOP-9818) Remove usage of "bash -c" from oah.fs.DF
Date Thu, 01 Aug 2013 23:33:48 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-9818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Andrew Wang reassigned HADOOP-9818:

    Assignee: Kousuke Saruta

Hi Kousuke, thanks for the patch!

I've made you a contributor, so now you should be able to assign Common JIRAs to yourself
and mark them as Patch Available via the "Submit Patch" button.

Part of the trickiness from removing "2>&1" is error handling. I haven't looked into
DF at all, but {{ProcessBuilder}} separates stdout and stderr, so stderr messages no longer
show up. So, I added another param to {{Shell}} in HADOOP-9652 (hopefully committed soon)
which merges them back together.

It'd be great if you can review the {{DF}} error handling behavior, especially adding tests
for any missing holes you find.
> Remove usage of "bash -c" from oah.fs.DF
> ----------------------------------------
>                 Key: HADOOP-9818
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9818
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Andrew Wang
>            Assignee: Kousuke Saruta
>              Labels: newbie
>         Attachments: HADOOP-9818.patch
> {{DF}} uses "bash -c" to shell out to the unix {{df}} command. This is potentially unsafe;
let's think about removing it.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message