hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10163) Attachment Id for last tested patch should be passed to test-patch.sh
Date Thu, 12 Dec 2013 22:47:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846852#comment-13846852
] 

Brock Noland commented on HADOOP-10163:
---------------------------------------

also later we match the file name.

{noformat}
# validate the patch name, parse branch if needed
shopt -s nocasematch
PATCH_NAME=$(basename $PATCH_URL)
# Test examples:
# HIVE-123.patch HIVE-123.1.patch HIVE-123.D123.patch HIVE-123.D123.1.patch HIVE-123-tez.patch
HIVE-123.1-tez.patch
# HIVE-XXXX.patch, HIVE-XXXX.XX.patch  HIVE-XXXX.XX-branch.patch HIVE-XXXX-branch.patch
if [[ $PATCH_NAME =~ ^HIVE-[0-9]+(\.[0-9]+)?(-[a-z0-9-]+)?\.(patch|patch.\txt)$ ]]
then
  if [[ -n "${BASH_REMATCH[2]}" ]]
  then
    BRANCH=${BASH_REMATCH[2]#*-}
  else
    echo "Assuming branch $BRANCH"
  fi
# HIVE-XXXX.DXXXX.patch or HIVE-XXXX.DXXXX.XX.patch
elif [[ $PATCH_NAME =~ ^(HIVE-[0-9]+\.)?D[0-9]+(\.[0-9]+)?\.(patch|patch.\txt)$ ]]
then
  echo "Assuming branch $BRANCH"
else
  echo "Patch $PATCH_NAME does not appear to be a patch"
  exit 1
fi
{noformat}

> Attachment Id for last tested patch should be passed to test-patch.sh
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-10163
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10163
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ted Yu
>
> In HBASE-10044, attempt was made to filter attachments according to known file extensions.
> However, that change alone wouldn't work because when non-patch is attached, QA bot doesn't
provide attachment Id for last tested patch.
> This results in the modified test-patch.sh to seek backward and launch duplicate test
run for last tested patch.
> If attachment Id for last tested patch is provided, test-patch.sh can decide whether
there is need to run test.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message