hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10208) Remove duplicate initialization in StringUtils.getStringCollection
Date Tue, 07 Jan 2014 21:01:50 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864682#comment-13864682
] 

Jing Zhao commented on HADOOP-10208:
------------------------------------

Nit: "import java.util.Collections;" can be removed from the new patch. +1 after addressing
the comment.

> Remove duplicate initialization in StringUtils.getStringCollection
> ------------------------------------------------------------------
>
>                 Key: HADOOP-10208
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10208
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>            Priority: Trivial
>         Attachments: HADOOP-10208.patch, HADOOP-10208.patch
>
>
> The *values* is initialized twice.
> {code:title=StringUtils.java|borderStyle=solid}
>  public static Collection<String> getStringCollection(String str){
>     List<String> values = new ArrayList<String>();
>     if (str == null)
>       return values;
>     StringTokenizer tokenizer = new StringTokenizer (str,",");
>     values = new ArrayList<String>();
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message