hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10085) CompositeService should allow adding services while being inited
Date Sat, 01 Feb 2014 13:28:14 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888573#comment-13888573
] 

Steve Loughran commented on HADOOP-10085:
-----------------------------------------

bq. Is there a need for the static method AddBlockingService#addChildService()? Why not just
call parent.addService?

Yes, as {{parent.addService()}} is protected. 





> CompositeService should allow adding services while being inited
> ----------------------------------------------------------------
>
>                 Key: HADOOP-10085
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10085
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Karthik Kambatla
>            Assignee: Steve Loughran
>         Attachments: HADOOP-10085-002.patch, HADOOP-10085-003.patch, HADOOP-10085-004.patch,
HADOOP-10085-005.patch
>
>
> We can add services to a CompositeService. However, if we do that while initing the CompositeService,
it leads to a ConcurrentModificationException.
> It would be nice to allow adding services even during the init of CompositeService.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message