hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10278) Refactor to make CallQueue pluggable
Date Wed, 19 Feb 2014 18:44:22 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905836#comment-13905836

Arpit Agarwal commented on HADOOP-10278:

Thanks Chris. Couple of comments and I apologize if these have been discussed already and
I missed it.

Overall the patch looks good. Would like to understand if there are any alternative use cases.
# Is this the only use case (admin changes the call queue at runtime for a specific port)?
Would it be useful to have a default global setting to refresh all ports without specifying
the port number?
# Will it be made available for other daemons apart from NN?

Also in {{refreshCallQueue}} perhaps you can skip the call to {{swapQueue}} if {{queueClassToUse}}
has not changed.

> Refactor to make CallQueue pluggable
> ------------------------------------
>                 Key: HADOOP-10278
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10278
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc
>            Reporter: Chris Li
>            Assignee: Chris Li
>         Attachments: HADOOP-10278-atomicref-adapter.patch, HADOOP-10278-atomicref-adapter.patch,
HADOOP-10278-atomicref-adapter.patch, HADOOP-10278-atomicref-adapter.patch, HADOOP-10278-atomicref-rwlock.patch,
HADOOP-10278-atomicref.patch, HADOOP-10278-atomicref.patch, HADOOP-10278-atomicref.patch,
HADOOP-10278-atomicref.patch, HADOOP-10278.patch, HADOOP-10278.patch
> * Refactor CallQueue into an interface, base, and default implementation that matches
today's behavior
> * Make the call queue impl configurable, keyed on port so that we minimize coupling

This message was sent by Atlassian JIRA

View raw message