hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10328) loadGenerator exit code is not reliable
Date Wed, 19 Feb 2014 20:23:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906019#comment-13906019
] 

Chris Nauroth commented on HADOOP-10328:
----------------------------------------

Hi, Haohui.  This patch looks good.  Just 2 minor things:
# The {{br.close()}} and {{fr.close()}} could instead use {{IOUtils#cleanup}} to save a line
of code and guard against {{IOException}} during closing.
# {{genFile}} could fail to close the file, because the close isn't in a finally block.  This
isn't directly related to your patch though.  The code was always this way.  If you prefer,
we could queue up a separate issue to address that.

> loadGenerator exit code is not reliable
> ---------------------------------------
>
>                 Key: HADOOP-10328
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10328
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 2.2.0
>            Reporter: Arpit Gupta
>            Assignee: Haohui Mai
>         Attachments: HADOOP-10328.000.patch
>
>
> LoadGenerator exit code is determined using the following logic
> {code}
> int exitCode = init(args);
>     if (exitCode != 0) {
>       return exitCode;
>     }
> {code}
> At the end of the run we just return the exitCode. So essentially if you are arguments
are correct you will always get 0 back.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message