hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10374) InterfaceAudience annotations should have RetentionPolicy.RUNTIME
Date Thu, 27 Feb 2014 23:30:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915200#comment-13915200
] 

Hadoop QA commented on HADOOP-10374:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12631609/hadoop-10374_v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-annotations.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3619//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3619//console

This message is automatically generated.

> InterfaceAudience annotations should have RetentionPolicy.RUNTIME
> -----------------------------------------------------------------
>
>                 Key: HADOOP-10374
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10374
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 3.0.0, 2.4.0
>
>         Attachments: hadoop-10374_v1.patch
>
>
> There are valid use cases for accessing the InterfaceAudience annotations programatically.

> In HBase, we are writing a unit test to check whether every class in the client packages
are annotated with one of the annotations. Plus, we are also thinking about a golden file
to containing all public method sigs, so that we can ensure public facing API-compatibility
from a unit test. 
> Related: HBASE-8546, HBASE-10462, HBASE-8275



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message