hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-3679) calls to junit Assert::assertEquals invert arguments, causing misleading error messages, other minor improvements.
Date Fri, 07 Mar 2014 23:28:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924484#comment-13924484
] 

Akira AJISAKA commented on HADOOP-3679:
---------------------------------------

Would you please keep the original code style to clean up the patch?
{code}
-    // Test Path(String) 
+    // Test Path(String)
{code}
False whilespace changes
{code}
     // URI#toString returns an encoded path
-    assertEquals("/foo%20bar", new URI(null, null, "/foo bar", null, null).toString());
+    assertEquals("/foo%20bar", 
+            new URI(null, null, "/foo bar", null, null).toString());
{code}
False newlines if there are no change in codes. If you want to render existing code, please
file a separate jira and create a patch.
{code}
+    assertArrayEquals(check,
+            Arrays.copyOf(dob.getData(), dob.getLength()));
{code}
You can also convert other lines like above into one line.

> calls to junit Assert::assertEquals invert arguments, causing misleading error messages,
other minor improvements.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3679
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3679
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: HADOOP-3679.2.patch, HADOOP-3679.3.patch, HADOOP-3679.4.patch, HADOOP-3679.patch
>
>
> JUnit Assert::assertEquals takes its expected and actual arguments in a particular order,
but many unit tests invert them. The error message from a failed assertion can be misleading.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message