hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10221) Add a plugin to specify SaslProperties for RPC protocol based on connection properties
Date Thu, 06 Mar 2014 00:50:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921731#comment-13921731
] 

Arpit Agarwal commented on HADOOP-10221:
----------------------------------------

My comments from reviewing the patch.
# The same CONSTRUCTOR_CACHE is used for both config and parameter-less constructor. Won’t
you get a RuntimeException if both methods are used for the same class? Use separate cache?
# Javadoc for {{constructInstance}} is confusing. Reword as ‘Create an object passing  the
configuration to the constructor itself’?
# Add a comment to the description of {{hadoop.rpc.protection}} stating that {{hadoop.security.saslproperties.resolver.class}}
can override it?
# {{ConnectionContext}} constructor has unnecessary {{super()}}?
# Nice use of parametrization to add a test case. {{AuthSaslPropertiesResolver}} appears unused
outside of tests, can we make it a static nested class of {{TestSaslRPC}}?
# Nitpick: Extra space in {{resolve (}} in SaslPropertiesResolver.java.
# Same in SaslRpcServer.java: {{resolver = SaslUtil.getResolver (conf);}}.
# Extra space in SaslUtil.java: {{public static  Map}}. Also {{static  boolean shouldEncrypt}}.
Please follow the coding convention.
# Nitpick: Redundant cast at SaslUtil.java:49?

Also the patch needs to be rebased (conflict in CommonConfigurationKeysPublic).

> Add a plugin to specify SaslProperties for RPC protocol based on connection properties
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10221
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10221
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.2.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>         Attachments: HADOOP-10221.patch, HADOOP-10221.patch, HADOOP-10221.patch, HADOOP-10221.patch
>
>
> Add a plugin to specify SaslProperties for RPC protocol based on connection properties.
> HADOOP-10211 enables client and server to specify and support multiple QOP.  Some connections
needs to be restricted to a specific set of QOP based on connection properties.
> Eg. connections from client from a specific subnet needs to be encrypted (QOP=privacy)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message