hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9159) FileSystem class should override .equals(Object)
Date Wed, 06 Aug 2014 01:28:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087083#comment-14087083
] 

Hadoop QA commented on HADOOP-9159:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12561804/HADOOP-9159.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ipc.TestRPCCallBenchmark
                  org.apache.hadoop.net.TestNetUtils
                  org.apache.hadoop.security.TestSecurityUtil
                  org.apache.hadoop.ipc.TestRPC
                  org.apache.hadoop.security.TestDoAsEffectiveUser
                  org.apache.hadoop.conf.TestConfiguration
                  org.apache.hadoop.fs.TestHarFileSystem
                  org.apache.hadoop.ipc.TestIPC

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4433//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4433//console

This message is automatically generated.

> FileSystem class should override .equals(Object)
> ------------------------------------------------
>
>                 Key: HADOOP-9159
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9159
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 1.1.1, 3.0.0
>            Reporter: Thejas M Nair
>            Assignee: Brandon Li
>         Attachments: HADOOP-9159.patch, HADOOP-9159.patch
>
>
> The FileSystem class has a notion of equality, based on the uri. The class should override
.equal(Object) so that it returns true if FileSystem objects are logically same. 
> This is useful when FileSystem cache is disabled, as FileSystem.get(..) will return new
object each time.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message