hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gil Vernik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10420) Add support to Swift-FS to support tempAuth
Date Sat, 16 Aug 2014 12:48:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099633#comment-14099633
] 

Gil Vernik commented on HADOOP-10420:
-------------------------------------

Great to have this driver. I only started to test it and have few comments so far:
1. Remove all 'SoftLayer' words which are still appears.

2. There is no 'objectURI' for the temp auth. TempAuthGet class contains
      // There is no object location in the authentication response in this case
      URI objectLocation = null;
      setAuthDetails(finalEndpointURI, objectLocation, accessToken);

But, the problem that 

 private URI pathToObjectLocation(SwiftObjectPath path) throws SwiftException {
    URI uri;
    String dataLocationURI = objectLocationURI.toString();
    try {
      if (path.toString().startsWith("/")) {
        dataLocationURI = dataLocationURI.concat(path.toUriPath());
      } else {
        dataLocationURI = dataLocationURI.concat("/").concat(path.toUriPath());
      }

      uri = new URI(dataLocationURI);
    } catch (URISyntaxException e) {
      throw new SwiftException(e);
    }
    return uri;
  }

Still requires object URI, which is null in case of temp auth.
Therefore:
14/08/16 15:20:43 TRACE org.apache.hadoop.fs.swift.http.SwiftRestClient: SwiftRestClient:
Executing getObjectLocation
java.lang.NullPointerException
        at org.apache.hadoop.fs.swift.http.SwiftRestClient.pathToObjectLocation(SwiftRestClient.java:769)
        at org.apache.hadoop.fs.swift.http.SwiftRestClient.getObjectLocation(SwiftRestClient.java:721)
        at org.apache.hadoop.fs.swift.snative.SwiftNativeFileSystemStore.getObjectLocation(SwiftNativeFileSystemStore.java:444)
        at org.apache.hadoop.fs.swift.snative.SwiftNativeFileSystem.getFileBlockLocations(SwiftNativeFileSystem.java:267)
.......

> Add support to Swift-FS to support tempAuth
> -------------------------------------------
>
>                 Key: HADOOP-10420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10420
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs, fs/swift, tools
>    Affects Versions: 2.3.0
>            Reporter: Jinghui Wang
>         Attachments: HADOOP-10420-002.patch, HADOOP-10420-003.patch, HADOOP-10420-004.patch,
HADOOP-10420.patch
>
>
> Currently, hadoop-openstack Swift FS supports keystone authentication. The attached patch
adds support for tempAuth. Users will be able to configure which authentication to use.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message