hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10835) Implement HTTP proxyuser support in HTTP authentication client/server libraries
Date Mon, 11 Aug 2014 21:26:14 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093321#comment-14093321
] 

Aaron T. Myers commented on HADOOP-10835:
-----------------------------------------

Patch looks pretty good to me, Tucu. A few small comments/nits. +1 once these are addressed.

Comments:

# Is it definitely correct that in {{DelegationTokenAuthenticationFilter#getProxyuserConfiguration}}
we create a {{Configuration}} object without loading the defaults? That surprised me a bit,
but maybe it's reasonable. Perhaps add a comment explaining why we're doing that here?
# Recommend using some constants for the many repeated strings in the tests, e.g. "ok-user"
is repeated many times.

Nits:

# This change seems unnecessary and unhelpful:
{code}
-   * Sets an external <code>DelegationTokenSecretManager</code> instance to
+   * Sets an external <code>  DelegationTokenSecretManager</code> instance to
{code}
# Should have a comma here, instead of a period:
{code}
+   * Returns the remote {@link UserGroupInformation} in context for the current
+   * HTTP request. taking into account proxy user requests.
{code}
# One too many "using":
{code}
+          // requests using using delegation token as auth do not honor doAs
{code}

> Implement HTTP proxyuser support in HTTP authentication client/server libraries
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-10835
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10835
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 2.4.1
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.6.0
>
>         Attachments: HADOOP-10835.patch, HADOOP-10835.patch, HADOOP-10835.patch
>
>
> This is to implement generic handling of proxyuser in the {{DelegationTokenAuthenticatedURL}}
and {{DelegationTokenAuthenticationFilter}} classes and to wire properly UGI on the server
side.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message