hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Steelman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11032) Replace use of Guava Stopwatch with Apache StopWatch
Date Mon, 01 Sep 2014 19:01:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117639#comment-14117639
] 

Gary Steelman commented on HADOOP-11032:
----------------------------------------

Thanks for touching the patch [~ozawa].

First, wow, that is a lot of failures. Any idea if the build scripts changed and that's the
reason we can't find SpanReceiverHost? Looks like every test failure is because of that. 

Second, I think a silent pass or a Log.warn() statement would suffice for StopWatch.stop()
twice in a row. Throwing an exception seems overkill to me. Do you think we should file a
Jira to do this?

And finally, if we remove the patch 3 attachment and re-upload it as patch 3 again, will Jenkins
will build with patch 3 again?

> Replace use of Guava Stopwatch with Apache StopWatch
> ----------------------------------------------------
>
>                 Key: HADOOP-11032
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11032
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Gary Steelman
>            Assignee: Tsuyoshi OZAWA
>         Attachments: HADOOP-11032.1.patch, HADOOP-11032.2.patch, HADOOP-11032.3.patch
>
>
> This patch reduces Hadoop's dependency on an old version of guava. Stopwatch.elapsedMillis()
isn't part of guava past v16 and the tools I'm working on use v17. 
> To remedy this and also reduce Hadoop's reliance on old versions of guava, we can use
the Apache StopWatch (org.apache.commons.lang.time.StopWatch) which provides nearly equivalent
functionality. apache.commons.lang is already a dependency for Hadoop so this will not introduce
new dependencies. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message