hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11057) checknative command to probe for winutils.exe on windows
Date Tue, 09 Sep 2014 23:48:28 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127810#comment-14127810
] 

Chris Nauroth commented on HADOOP-11057:
----------------------------------------

This looks good.  I tested on Mac, Windows and Linux.  I have just 2 suggestions:
# {{NativeLibraryChecker}}: Let's call {{Shell#getWinUtilsPath}} just once and save its return
value in a temporary variable.  That code path in {{Shell}} ultimately triggers a little disk
I/O via {{File#getCanonicalPath}}, so it's best to do it only once.
# {{TestNativeLibraryChecker}}: The last line of code looks like it's trying to restore the
original stdout, but at this point, {{System.out}} was changed by the earlier call to {{System#setOut}},
so it's really just setting it to the same value again.  I think you'll want to save the initial
value of {{System.out}} before the first call to {{System#setOut}}, and then restore to that.

> checknative command to probe for winutils.exe on windows
> --------------------------------------------------------
>
>                 Key: HADOOP-11057
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11057
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: native
>    Affects Versions: 2.5.0
>         Environment: windows
>            Reporter: Steve Loughran
>            Assignee: Xiaoyu Yao
>            Priority: Minor
>             Fix For: 2.4.1
>
>         Attachments: HADOOP-11057.0.patch, HADOOP-11057.1.patch, HADOOP-11057.2.patch
>
>
> hadoop's {{checknative}} command looks for native binaries and returns an error code
if one is missing.
> But it doesn't check for {{winutils.exe}} on windows, which turns out to be essential
for some operations. 
> Adding this check to the -a (or default) operation would allow the check to be used as
a health check on windows installations



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message