hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11073) Credential Provider related Unit Tests Failure on Windows
Date Sun, 07 Sep 2014 16:39:28 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124962#comment-14124962
] 

Hadoop QA commented on HADOOP-11073:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12667064/HADOOP-11073.1.patch
  against trunk revision a23144f.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 5 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4666//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4666//console

This message is automatically generated.

> Credential Provider related Unit Tests Failure on Windows
> ---------------------------------------------------------
>
>                 Key: HADOOP-11073
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11073
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: security
>    Affects Versions: 2.4.1
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HADOOP-11073.0.patch, HADOOP-11073.1.patch
>
>
> Reported by: Xiaomara and investigated by [~cnauroth].
> The credential provider related unit tests failed on Windows. The tests try to set up
a URI by taking the build test directory and concatenating it with other strings containing
the rest of the URI format, i.e.:
> {code}
>   public void testFactory() throws Exception {
>     Configuration conf = new Configuration();
>     conf.set(CredentialProviderFactory.CREDENTIAL_PROVIDER_PATH,
>         UserProvider.SCHEME_NAME + ":///," +
>             JavaKeyStoreProvider.SCHEME_NAME + "://file" + tmpDir + "/test.jks");
> {code}
> This logic is incorrect on Windows, because the file path separator will be '\', which
violates URI syntax. Forward slash is not permitted. 
> The proper fix is to always do path/URI construction through the org.apache.hadoop.fs.Path
class, specifically using the constructors that take explicit parent and child arguments.
> The affected unit tests are:
> {code}
> * TestKeyProviderFactory
> * TestLdapGroupsMapping
> * TestCredentialProviderFactory
> * KeyStoreTestUtil
> * TestSSLFactory
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message