hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11074) Move s3-related FS connector code to hadoop-aws
Date Wed, 10 Sep 2014 07:54:29 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128196#comment-14128196
] 

Steve Loughran commented on HADOOP-11074:
-----------------------------------------

the test. params for the FSContract test should go into 'auth-keys.xml' a la openstack ...that
setup is designed to stop anyone accidentally committing their secret keys.

it could (and the openstack & azure modules) reworked to use {{contract-test-options.xml}}.
All we need is one file to enable the test run.

If you think about *why* we need that option, it is that the classic {{FileSystemContractBaseTest}}
is a junit 3 lib, and you can't use {{Assert.assume()}} to skip tests there. The ideal fix
would be do clone that into a Junit 4 test case, then {{@deprecate}} the original so that
other FS impls can still use it for now. Not for this patch though.

h2. findbugs

Presumably all of those bugs were hidden before. I'd recommend copying over the hadoop-common
excludes to make the warnings go away —so that changes to the source will go into a later
patch. This one can just move the code and fix the POMs

> Move s3-related FS connector code to hadoop-aws
> -----------------------------------------------
>
>                 Key: HADOOP-11074
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11074
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.0.0
>            Reporter: David S. Wang
>            Assignee: David S. Wang
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-11074.patch, HADOOP-11074.patch.2
>
>
> Now that hadoop-aws has been created, we should actually move the relevant code into
that module, similar to what was done with hadoop-openstack, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message