hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-11101) How about inputstream close statement from catch block to finally block in FileContext#copy() ?
Date Thu, 25 Sep 2014 07:27:34 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-11101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vinayakumar B updated HADOOP-11101:
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 2.6.0
           Status: Resolved  (was: Patch Available)

[~rsk13th], I am not able to assign to you as of now. I think because your name is not in
contributors list.
I will ask someone to add your name to list and assign to you later.

> How about inputstream close statement from catch block to finally block in FileContext#copy()
?
> -----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11101
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11101
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.5.1
>            Reporter: skrho
>            Priority: Minor
>             Fix For: 2.6.0
>
>         Attachments: HADOOP-11101_001.patch, HADOOP-11101_002.patch, HADOOP-11101_003.patch
>
>
> If IOException is happended, can be catched exception block.. 
> But another excpetion is happended, can't be catched exception block.. also Stream object
can't be closed..
>         try {
>           in = open(qSrc);
>           EnumSet<CreateFlag> createFlag = overwrite ? EnumSet.of(
>               CreateFlag.CREATE, CreateFlag.OVERWRITE) : 
>                 EnumSet.of(CreateFlag.CREATE);
>           out = create(qDst, createFlag);
>           IOUtils.copyBytes(in, out, conf, true);
>         } catch (IOException e) {
>           IOUtils.closeStream(out);
>           IOUtils.closeStream(in);
>           throw e;
>         }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message