hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10404) Some accesses to DomainSocketWatcher#closed are not protected by lock
Date Mon, 06 Oct 2014 20:22:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160869#comment-14160869
] 

Hadoop QA commented on HADOOP-10404:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12634221/HADOOP-10404.003.patch
  against trunk revision ea26cc0.

    {color:red}-1 patch{color}.  Trunk compilation may be broken.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4869//console

This message is automatically generated.

> Some accesses to DomainSocketWatcher#closed are not protected by lock
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-10404
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10404
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-10404.003.patch, HADOOP-10404.1.patch, HADOOP-10404.2.patch
>
>
> {code}
>    * Lock which protects toAdd, toRemove, and closed.
>    */
>   private final ReentrantLock lock = new ReentrantLock();
> {code}
> There're two places, NotificationHandler.handle() and kick(), where access to closed
is without holding lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message