hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10404) Some accesses to DomainSocketWatcher#closed are not protected by lock
Date Tue, 07 Oct 2014 11:40:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161790#comment-14161790
] 

Hudson commented on HADOOP-10404:
---------------------------------

FAILURE: Integrated in Hadoop-Yarn-trunk #704 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/704/])
HADOOP-10404. Some accesses to DomainSocketWatcher#closed are not protected by the lock (cmccabe)
(cmccabe: rev 8099de259fb91a29674bf17cb1382c038b707a90)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/unix/DomainSocketWatcher.java
* hadoop-common-project/hadoop-common/CHANGES.txt
HADOOP-10404.  Commit correct version of patch (cmccabe) (cmccabe: rev 687d83c9e10a4432c8d54c2cd406c7ccb4392187)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/unix/DomainSocketWatcher.java


> Some accesses to DomainSocketWatcher#closed are not protected by lock
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-10404
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10404
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: HADOOP-10404.003.patch, HADOOP-10404.1.patch, HADOOP-10404.2.patch
>
>
> {code}
>    * Lock which protects toAdd, toRemove, and closed.
>    */
>   private final ReentrantLock lock = new ReentrantLock();
> {code}
> There're two places, NotificationHandler.handle() and kick(), where access to closed
is without holding lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message