hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10404) Some accesses to DomainSocketWatcher#closed are not protected by lock
Date Wed, 08 Oct 2014 18:16:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163902#comment-14163902
] 

Andrew Wang commented on HADOOP-10404:
--------------------------------------

Hey Colin, do you want to merge this down to 2.6 also? I've seen a few JIRAs filed about thread
leaks related to DSW leading to hung DNs, seems like a pretty important fix.

> Some accesses to DomainSocketWatcher#closed are not protected by lock
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-10404
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10404
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: HADOOP-10404.003.patch, HADOOP-10404.1.patch, HADOOP-10404.2.patch
>
>
> {code}
>    * Lock which protects toAdd, toRemove, and closed.
>    */
>   private final ReentrantLock lock = new ReentrantLock();
> {code}
> There're two places, NotificationHandler.handle() and kick(), where access to closed
is without holding lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message