hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Larry McCay (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11161) Expose close method in KeyProvider to give clients of Provider implementations a hook to release resources
Date Fri, 03 Oct 2014 19:27:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158402#comment-14158402
] 

Larry McCay commented on HADOOP-11161:
--------------------------------------

hmmm...
It seems to me that if you shouldn't use the provider after calling close() that it is a lifecycle
method - you just killed it. That is how I read what you said - that it shouldn't be used
again. If that isn't true then I am less concerned.

Otherwise, I just wanted to make sure that if we were introducing a lifecycle that each stage
is represented. Seems like the need for the close() may be pointing out  a smell in the original
design of KeyProvider or of the extension for crypto. We just need to address the whole smell.
:)

If there is no larger issue and closing and throwing away a provider after each use solves
all such circumstances - then that may be just fine.

Just some thoughts.

> Expose close method in KeyProvider to give clients of Provider implementations a hook
to release resources
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11161
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: HADOOP-11161.1.patch, HADOOP-11161.2.patch, HADOOP-11161.3.patch
>
>
> The {{KMSClientProvider}} class needs to be have a {{close()}} method to shutdown back
ground executor threads.
> The {{DFSClient}} creates an instance of a {{KeyProvider}} during initialization. If
this KP is a {{KMSClientProvider}}, this needs to be closed to prevent thread leakage



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message