hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11161) Expose close method in KeyProvider to give clients of Provider implementations a hook to release resources
Date Fri, 03 Oct 2014 19:50:37 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158435#comment-14158435
] 

Aaron T. Myers commented on HADOOP-11161:
-----------------------------------------

I think in general a lot of classes support a {{close()}} method to indicate that internal
resources can be released, that don't need to go whole-hog with a life cycle state machine.
That's why java has the {{Closeable}} interface in the first place.

In any case, I think we can entirely reasonably add a {{close()}} call now, and revisit the
need for an {{init()}} method at a later time. Given the fact that we're introducing a no-op
concrete method, and not an abstract method, there should be no compatibility implications
here.

Larry, to be explicit, are you OK with me committing the latest patch as-is?

> Expose close method in KeyProvider to give clients of Provider implementations a hook
to release resources
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11161
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: HADOOP-11161.1.patch, HADOOP-11161.2.patch, HADOOP-11161.3.patch
>
>
> The {{KMSClientProvider}} class needs to be have a {{close()}} method to shutdown back
ground executor threads.
> The {{DFSClient}} creates an instance of a {{KeyProvider}} during initialization. If
this KP is a {{KMSClientProvider}}, this needs to be closed to prevent thread leakage



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message