hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11454) Potential null dereference in Configuration#loadProperty()
Date Sun, 04 Jan 2015 02:28:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263722#comment-14263722
] 

Ted Yu commented on HADOOP-11454:
---------------------------------

I don't think the findbugs warnings are related to my patch.
I downloaded the following files and performed a diff:
{code}
$ diff patchFindbugsWarningshadoop-common.xml newPatchFindbugsWarningshadoop-common.xml
152c152
<   <FindBugsSummary timestamp="Tue, 30 Dec 2014 21:22:10 +0000" total_classes="3726"
referenced_classes="2946" total_bugs="2" total_size="163624" num_packages="71" vm_version="24.55-b03"
cpu_seconds="1.03" clock_seconds="0.34" peak_mbytes="101.10" alloc_mbytes="723.50" gc_seconds="0.00"
priority_2="2">
---
>   <FindBugsSummary timestamp="Tue, 30 Dec 2014 21:22:10 +0000" total_classes="1863"
referenced_classes="2946" total_bugs="2" total_size="81812" num_packages="71" vm_version="24.55-b03"
cpu_seconds="0.90" clock_seconds="0.30" peak_mbytes="104.95" alloc_mbytes="723.50" gc_seconds="0.00"
priority_2="2">
2159c2159
<       <ClassProfile name="edu.umd.cs.findbugs.SAXBugCollectionHandler" totalMilliseconds="290"
invocations="1" avgMicrosecondsPerInvocation="290527" maxMicrosecondsPerInvocation="290527"
standardDeviationMircosecondsPerInvocation="0"/>
---
>       <ClassProfile name="edu.umd.cs.findbugs.SAXBugCollectionHandler" totalMilliseconds="238"
invocations="1" avgMicrosecondsPerInvocation="238237" maxMicrosecondsPerInvocation="238237"
standardDeviationMircosecondsPerInvocation="0"/>
{code}
I don't see new warning introduced.

> Potential null dereference in Configuration#loadProperty()
> ----------------------------------------------------------
>
>                 Key: HADOOP-11454
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11454
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: hadoop-11454-001.patch
>
>
> Here is related code:
> {code}
> 2581             properties.setProperty(attr, value);
> 2582             updatingResource.put(attr, source);
> 2583           } else if (!value.equals(properties.getProperty(attr))) {
> {code}
> The null check in the enclosing if statement is accompanied with allowNullValueProperties,
thus dereferencing value above may result in NPE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message