hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9565) Add a Blobstore interface to add to blobstore FileSystems
Date Mon, 02 Feb 2015 18:32:36 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301606#comment-14301606

Chris Nauroth commented on HADOOP-9565:

This is nice work, Steve.  Thanks for putting this together.  Here are a few comments:

# Have you considered attaching semantics directly to {{FileSystem}} and {{FileContext}} instead
of introducing the {{ObjectStore}} abstract base class?  This could give us a modest simplification
of calling code, because it wouldn't have to downcast, either directly or implicitly by taking
the extra hop through the static {{ObjectStore#hasStoreSemantics}}.
# Shall we change {{StoreSemantics}} to an enum and then phrase the API in terms of {{EnumSet<StoreSemantics>}}
for improved type safety?  There is existing precedent for use of {{EnumSet}} in the {{FileSystem}}
API, so I expect callers will find it familiar.

> Add a Blobstore interface to add to blobstore FileSystems
> ---------------------------------------------------------
>                 Key: HADOOP-9565
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9565
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs, fs/s3, fs/swift
>    Affects Versions: 2.6.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: HADOOP-9565-001.patch, HADOOP-9565-002.patch, HADOOP-9565-003.patch
> We can make the fact that some {{FileSystem}} implementations are really blobstores,
with different atomicity and consistency guarantees, by adding a {{Blobstore}} interface to
add to them. 
> This could also be a place to add a {{Copy(Path,Path)}} method, assuming that all blobstores
implement at server-side copy operation as a substitute for rename.

This message was sent by Atlassian JIRA

View raw message