hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9869) Configuration.getSocketAddr()/getEnum() should use getTrimmed()
Date Thu, 12 Feb 2015 20:24:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318920#comment-14318920
] 

Hadoop QA commented on HADOOP-9869:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12661111/HADOOP-9869.4.patch
  against trunk revision 83be450.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5675//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5675//console

This message is automatically generated.

>  Configuration.getSocketAddr()/getEnum() should use getTrimmed()
> ----------------------------------------------------------------
>
>                 Key: HADOOP-9869
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9869
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 3.0.0, 2.1.0-beta, 1.3.0
>            Reporter: Steve Loughran
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: HADOOP-9869.1.patch, HADOOP-9869.2.patch, HADOOP-9869.3.patch, HADOOP-9869.4.patch
>
>
> YARN-1059 has shown that the hostname:port string used for the address of things like
the RM isn't trimmed before its parsed, leading to errors that aren't that obvious. 
> We should trim it -it's clearly not going to break any existing (valid) configurations



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message