hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10953) a minor concurrent bug inside NetworkTopology
Date Tue, 10 Feb 2015 00:17:37 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313230#comment-14313230

Colin Patrick McCabe commented on HADOOP-10953:

+1 pending jenkins

> a minor concurrent bug inside NetworkTopology
> ---------------------------------------------
>                 Key: HADOOP-10953
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10953
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: net
>    Affects Versions: 3.0.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>         Attachments: HADOOP-10953.txt
> Found this issue while reading the related code. In NetworkTopology.toString() method,
there is no thread safety guarantee directly, it's called by add/remove, and inside add/remove,
most of this.toString() calls are protected by rwlock, except a couple of error handling codes,
one possible fix is that moving them into lock as well, due to not heavy operations, so no
obvious downgration should be observed per my current knowledge.

This message was sent by Atlassian JIRA

View raw message