hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10953) NetworkTopology#add calls NetworkTopology#toString without holding the netlock
Date Tue, 10 Feb 2015 20:15:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314824#comment-14314824
] 

Hadoop QA commented on HADOOP-10953:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12660965/HADOOP-10953.txt
  against trunk revision 3f5431a.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5644//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5644//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5644//console

This message is automatically generated.

> NetworkTopology#add calls NetworkTopology#toString without holding the netlock
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-10953
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10953
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: net
>    Affects Versions: 3.0.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>         Attachments: HADOOP-10953.txt
>
>
> Found this issue while reading the related code. In NetworkTopology.toString() method,
there is no thread safety guarantee directly, it's called by add/remove, and inside add/remove,
most of this.toString() calls are protected by rwlock, except a couple of error handling codes,
one possible fix is that moving them into lock as well, due to not heavy operations, so no
obvious downgration should be observed per my current knowledge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message