hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11042) CryptoInputStream throwing wrong exception class on errors
Date Sat, 07 Feb 2015 19:55:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310898#comment-14310898
] 

Hadoop QA commented on HADOOP-11042:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12665868/HADOOP-11042.001.patch
  against trunk revision cfb829e.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 17 new or modified
test files.

    {color:red}-1 javac{color:red}.  The patch appears to cause the build to fail.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5630//console

This message is automatically generated.

> CryptoInputStream throwing wrong exception class on errors
> ----------------------------------------------------------
>
>                 Key: HADOOP-11042
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11042
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Steve Loughran
>            Assignee: Yi Liu
>         Attachments: HADOOP-11042.001.patch
>
>
> Having had a quick look at the {{CryptoInputStream}} class, it's not in sync with all
the other filesystem's exception logic, as specified in {{src/site/markdown/filesystem/fsdatainputstream.md}}
> Operations MUST throw an {{IOException}} on out of bounds reads, ideally {{EOFException}}
:
> # {{read(byte[] b, int off, int len)}} 
> # {{seek(long pos) }}
> # {{seekToNewSource}}
> The tests you want to extend to verify expected behaviour are in {{AbstractContractOpenTest}}
and {{AbstractContractSeekTest}}
> also, the {{HasEnhancedByteBufferAccess}} implementations may want to think about using
{{checkStream()}} before acting on a potentially closed stream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message