hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11534) Minor improvements for raw erasure coders
Date Mon, 02 Feb 2015 07:01:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300946#comment-14300946
] 

Vinayakumar B commented on HADOOP-11534:
----------------------------------------

Thanks [~drankye] for the patch.
One comment,

{code}+        bytesArr[i] = new byte[buffer.remaining()];
+        // Avoid affecting the original one
+        buffer.duplicate().get(bytesArr[i]);{code}
Here since its just reading the data from buffer, I feel data wont be affected. Only position
will be changed. To retain the position you can make use of {{mark()}} and {{reset()}} instead
of {{duplicate()}} to avoid extra Object creation. What you say..?

Other changes looks fine.

> Minor improvements for raw erasure coders
> -----------------------------------------
>
>                 Key: HADOOP-11534
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11534
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: HDFS-EC
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>            Priority: Minor
>             Fix For: HDFS-EC
>
>         Attachments: HADOOP-11534-v1.patch
>
>
> For the raw erasure coder API codes introduced by HADOOP-11514, there're some minor improvements
that were noticed and can be done separately.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message