hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11418) Property "io.compression.codec.lzo.class" does not work with other value besides default
Date Tue, 10 Mar 2015 02:07:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354123#comment-14354123
] 

Akira AJISAKA commented on HADOOP-11418:
----------------------------------------

bq. It looks like a little strange.
I agree with you. Rethinking this, the below looks clear to me. What do you think?
{code}
  String extClazz = (extClazz_conf == null) ?
      System.getProperty(CONF_LZO_CLASS) : extClazz_conf;
{code}
Would you please add a regression test? If you don't want to add it, I'd like to succeed your
work.

> Property "io.compression.codec.lzo.class" does not work with other value besides default
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11418
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11418
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>            Reporter: fang fang chen
>            Assignee: fang fang chen
>         Attachments: HADOOP-11418-1.patch, HADOOP-11418-2.patch, HADOOP-11418-3.patch,
HADOOP-11418.patch
>
>
> From following code, seems "io.compression.codec.lzo.class" does not work for other codec
besides default. Hadoop will always treat it as defaultClazz. I think it is a bug. Please
let me know if this is a work as design thing. Thanks
>      77       private static final String defaultClazz =
>      78           "org.apache.hadoop.io.compress.LzoCodec";
>      82       public synchronized boolean isSupported() {
>      83         if (!checked) {
>      84           checked = true;
>      85           String extClazz =
>      86               (conf.get(CONF_LZO_CLASS) == null ? System
>      87                   .getProperty(CONF_LZO_CLASS) : null);
>      88           String clazz = (extClazz != null) ? extClazz : defaultClazz;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message