hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11418) Property "io.compression.codec.lzo.class" does not work with other value besides default
Date Wed, 04 Mar 2015 00:31:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346101#comment-14346101
] 

Akira AJISAKA commented on HADOOP-11418:
----------------------------------------

bq. And the regression test has been made with pig before, here is the process and log:
The log looks good to me, however, I'd like to add a regression test in hadoop side also.
I'm not sure PIG-4341 will be merged soon.
{code}
+              (extClazz_conf == null ? System.getProperty(CONF_LZO_CLASS) : extClazz_conf);
{code}
* The line contains unnecessary parentheses. Would you remove them?
* The line is longer than 80 characters. Would you render it within 80 characters?

> Property "io.compression.codec.lzo.class" does not work with other value besides default
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11418
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11418
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>            Reporter: fang fang chen
>            Assignee: fang fang chen
>         Attachments: HADOOP-11418-1.patch, HADOOP-11418.patch
>
>
> From following code, seems "io.compression.codec.lzo.class" does not work for other codec
besides default. Hadoop will always treat it as defaultClazz. I think it is a bug. Please
let me know if this is a work as design thing. Thanks
>      77       private static final String defaultClazz =
>      78           "org.apache.hadoop.io.compress.LzoCodec";
>      82       public synchronized boolean isSupported() {
>      83         if (!checked) {
>      84           checked = true;
>      85           String extClazz =
>      86               (conf.get(CONF_LZO_CLASS) == null ? System
>      87                   .getProperty(CONF_LZO_CLASS) : null);
>      88           String clazz = (extClazz != null) ? extClazz : defaultClazz;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message