hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11626) Comment ReadStatistics to indicate that it tracks the actual read occurred
Date Mon, 02 Mar 2015 22:09:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343859#comment-14343859
] 

Hadoop QA commented on HADOOP-11626:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12701936/HADOOP-11626.001.patch
  against trunk revision ca1c00b.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5815//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5815//console

This message is automatically generated.

> Comment ReadStatistics to indicate that it tracks the actual read occurred
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-11626
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11626
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Trivial
>         Attachments: HADOOP-11626.000.patch, HADOOP-11626.001.patch
>
>
> In {{DFSOutputStream#actualGetFromOneDataNode()}}, it updates the {{ReadStatistics}}
even the read is failed:
> {code}
>         int nread = reader.readAll(buf, offset, len);
>         updateReadStatistics(readStatistics, nread, reader);
>         if (nread != len) {
>           throw new IOException("truncated return from reader.read(): " +
>                                 "excpected " + len + ", got " + nread);
>         }
> {code}
> It indicates that {{ReadStatistics}} tracks actual read occurred. Need to add comment
to {{ReadStatistics}} to make this clear.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message