hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gera Shegalov (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HADOOP-11659) o.a.h.fs.FileSystem.Cache#remove should use a single hash map lookup
Date Mon, 02 Mar 2015 09:38:04 GMT
Gera Shegalov created HADOOP-11659:
--------------------------------------

             Summary: o.a.h.fs.FileSystem.Cache#remove should use a single hash map lookup
                 Key: HADOOP-11659
                 URL: https://issues.apache.org/jira/browse/HADOOP-11659
             Project: Hadoop Common
          Issue Type: Improvement
          Components: fs
    Affects Versions: 2.6.0
            Reporter: Gera Shegalov
            Priority: Trivial


The method looks up the same key in the same hash map potentially 3 times
{code}
if (map.containsKey(key) && fs == map.get(key)) {
  map.remove(key)
{code}

Instead it could do a single lookup
{code}
FileSystem cachedFs = map.remove(key);
{code}

and then test cachedFs == fs or something else.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message