hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11746) rewrite test-patch.sh
Date Wed, 08 Apr 2015 17:36:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485609#comment-14485609
] 

Chris Nauroth commented on HADOOP-11746:
----------------------------------------

As per discussion on common-dev, we'd like to be able to exit early from test-patch runs against
an attachment if the file name doesn't match *.patch.  This would cut down on spam from Jenkins
trying to run test-patch on other kinds of attachments, like screenshots and design docs.

Another potential improvement on top of that would be to skip runs if the patch file name
contains a branch name, because we only do pre-commit for trunk currently.

Just as a reminder, naming conventions for patch files are documented here:

https://wiki.apache.org/hadoop/HowToContribute#Naming_your_patch


> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch,
HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch,
HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch
>
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message