hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-11746) rewrite test-patch.sh
Date Thu, 09 Apr 2015 04:27:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486660#comment-14486660
] 

Allen Wittenauer edited comment on HADOOP-11746 at 4/9/15 4:27 AM:
-------------------------------------------------------------------

-12:
* add --resetrepo to simulate jenkins git repo nuker in developer mode
* don't send a jira message and abort early if the URL doesn't end in .patch
* Allow git(8 chars) or git(41 chars) as branch names for patch testing
* make it explicit in the report output if we were in branch or git ref mode
* fix some issues with checkstyle
* when using --resetrepo mode, shellcheck would erroneously flag .orig and .rej files from
previous patches since those aren't cleared by git due to .gitignore
* fix a few shellcheck warnings I had missed. (shellcheck is still mostly ignoring dev-support.
should probably fix that.)
* findbugs now gives a summary report on the console/jira output rather than forcing folks
to look at the full findbugs output (altho that is still listed too!)
* set the TIMER default at startup to be current time rather 0 to prevent incredibly bogus,
decades long runtimes in case of early aborts
* re-order the flags in the options parser
* fix an issue with the test heuristics so that external plugins aren't prematurely ignored

Testing itself, it says:

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 00m 00s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 00m 00s | Pre-patch trunk compilation is healthy. |
| {color:red}-1{color} | @author | 00m 00s | The patch appears to contain 13 @author tags
which the Hadoop  community has agreed to not allow in code contributions. |
| {color:green}+1{color} | whitespace | 00m 00s | The patch has no   lines that end in whitespace.
|
| {color:green}+1{color} | release audit | 00m 09s | The applied patch does not increase the
total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 00m 02s | There were no new shellcheck issues. |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | shellcheck |
| git revision | f4b3fc5 / trunk |
| Console output | /artifact/patchprocess/console |


This message was automatically generated.


was (Author: aw):
-12:
* add --resetrepo to simulate jenkins git repo nuker in developer mode
* don't send a jira message and abort early if the URL doesn't end in .patch
* Allow git(8 chars) or git(41 chars) as branch names for patch testing
* make it explicit in the report output if we were in branch or git ref mode
* fix some issues with checkstyle
* when using --resetrepo mode, shellcheck would erroneously flag .orig and .rej files from
previous patches since those aren't cleared by git due to .gitignore
* fix a few shellcheck warnings I had missed
* findbugs now gives a summary report on the console/jira output rather than forcing folks
to look at the full findbugs output (altho that is still listed too!)
* set the TIMER to be current time rather 0 to prevent incredibly bogus, decades long runtimes
in case of early aborts
* re-order the flags in the options parser
* fix an issue with the test heuristics so that external plugins aren't prematurely ignored

Testing itself, it says:

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 00m 00s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 00m 00s | Pre-patch trunk compilation is healthy. |
| {color:red}-1{color} | @author | 00m 00s | The patch appears to contain 13 @author tags
which the Hadoop  community has agreed to not allow in code contributions. |
| {color:green}+1{color} | whitespace | 00m 00s | The patch has no   lines that end in whitespace.
|
| {color:green}+1{color} | release audit | 00m 09s | The applied patch does not increase the
total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 00m 02s | There were no new shellcheck issues. |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | shellcheck |
| git revision | f4b3fc5 / trunk |
| Console output | /artifact/patchprocess/console |


This message was automatically generated.

> rewrite test-patch.sh
> ---------------------
>
>                 Key: HADOOP-11746
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11746
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build, test
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, HADOOP-11746-02.patch,
HADOOP-11746-03.patch, HADOOP-11746-04.patch, HADOOP-11746-05.patch, HADOOP-11746-06.patch,
HADOOP-11746-07.patch, HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch,
HADOOP-11746-12.patch
>
>
> This code is bad and you should feel bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message