hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12053) Harfs defaulturiport should be Zero ( should not -1)
Date Sun, 01 Nov 2015 22:03:27 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984570#comment-14984570
] 

Chris Nauroth commented on HADOOP-12053:
----------------------------------------

Hi [~brahmareddy] and [~jira.shegalov].  From a quick scan, this looks like a good change
to make.  However, I'm reluctant to squeeze it in if Vinod is in progress on a 2.7.2 RC right
now.  While there is some loss of functionality, it isn't dangerous like a data loss.  I'd
prefer to give this more time for a full code review and thorough testing.

I'll bump this up in my queue for full review.

> Harfs defaulturiport should be Zero ( should not -1)
> ----------------------------------------------------
>
>                 Key: HADOOP-12053
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12053
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Gera Shegalov
>            Priority: Critical
>         Attachments: HADOOP-12053.001.patch, HADOOP-12053.002.patch, HADOOP-12053.003.patch
>
>
> The harfs overrides the "getUriDefaultPort" method of AbstractFilesystem, and returns
"-1" . But "-1" can't pass the "checkPath" method when the {{fs.defaultfs}} is setted without
port(like hdfs://hacluster)
>  *Test Code :* 
> {code}
> for (FileStatus file : files) {
>           String[] edges = file.getPath().getName().split("-");
>           if (applicationId.toString().compareTo(edges[0]) >= 0 && applicationId.toString().compareTo(edges[1])
<= 0) {
>             Path harPath = new Path("har://" + file.getPath().toUri().getPath());
>             harPath = harPath.getFileSystem(conf).makeQualified(harPath);
>             remoteAppDir = LogAggregationUtils.getRemoteAppLogDir(
>                 harPath, applicationId, appOwner,
>                 LogAggregationUtils.getRemoteNodeLogDirSuffix(conf));
>             if (FileContext.getFileContext(remoteAppDir.toUri()).util().exists(remoteAppDir))
{
>                 remoteDirSet.add(remoteAppDir);
>             }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message